Skip to content

add orderBy: computed test #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 31, 2025
Merged

add orderBy: computed test #2486

merged 12 commits into from
May 31, 2025

Conversation

joleeee
Copy link
Contributor

@joleeee joleeee commented May 13, 2025 •
edited
Loading

Description

Adds a test. Using orderBy: someComputedColumn.

Performance impact

Security impact

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 May 13, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb82225

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joleeee
Copy link
Contributor Author

joleeee commented May 14, 2025

Can you approve the workflows @benjie

@joleeee joleeee changed the title add failing computed orderby test add orderBy: computed test May 14, 2025
@joleeee joleeee marked this pull request as ready for review May 14, 2025 12:37
@benjie
Copy link
Member

benjie commented May 19, 2025

You need to run the full test suite with UPDATE_SNAPSHOTS=1 because the schema snapshots need updating.

benjie
benjie previously approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test! 🙌

@github-project-automation github-project-automation bot moved this from 🌳 Triage to 🌱 In Progress in V5.0.0 May 31, 2025
@benjie benjie merged commit 37ff807 into graphile:main May 31, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 🌱 In Progress to ✅ Done in V5.0.0 May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
V5.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joleeee @benjie